target/riscv: pass memory access info in struct, move write_memory pointer #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en-sc
approved these changes
Nov 14, 2024
fk-sc
force-pushed
the
fk-sc/rwargs
branch
3 times, most recently
from
13ccb02 to
dbfd2fa
Compare
en-sc
previously approved these changes
Nov 19, 2024
Fixed |
|
@JanMatCodasip, @MarekVCodasip, could you please take a look? |
fk-sc
force-pushed
the
fk-sc/rwargs
branch
4 times, most recently
from
c61d424 to
bcf9bab
Compare
fk-sc
force-pushed
the
fk-sc/rwargs
branch
3 times, most recently
from
d94c888 to
01501b0
Compare
…inter
This changes will allow to unite read_memory/write_memory fucntions
to one access function
(1) Replaced read/write functions arguments with one structure
(2) Unified read_memory/write_memory function pointers
to be stored in same structure
Signed-off-by: Farid Khaydari <[email protected]>
en-sc
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes will allow to unite read_memory/write_memory functions to one access function
(1) Replaced read/write functions arguments with one structure
(2) Unified read_memory/write_memory function pointers to be stored in same structure