feat: add UNL to get_network API
#60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdp2121
approved these changes
Dec 6, 2022
ckniffen
reviewed
Dec 14, 2022
| { | ||
| action: 'Get Network From Node', | ||
| route: '/v1/network/get_network', | ||
| example: 'https://data.xrpl.org/v1/network/get_network', |
There was a problem hiding this comment.
The example should include that it takes a parameter.
pdp2121
reviewed
Dec 14, 2022
| @@ -11,6 +11,11 @@ const log = logger({ name: 'api-get-network' }) | |||
|
|
|||
| const CRAWL_PORTS = [51235, 2459, 30001] | |||
|
|
|||
| interface NetworkInfo { | |||
| network: string | |||
| unl?: string[] | |||
There was a problem hiding this comment.
Should it just be a string based on the functions below?
pdp2121
reviewed
Dec 14, 2022
| if (result.length > 0) { | ||
| return { | ||
| network: result[0].id, | ||
| unl: result[0].unls.split(',')[0], |
There was a problem hiding this comment.
Should we just show all unls similar to getNetworkInfoFromPublicKey below?
|
@mvadari is this PR still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Title says it all. This PR also documents the
get_networkAPI.Context of Change
This is necessary for ripple/explorer#470
Type of Change
Before / After
Test Plan
Works locally.