YAML specification for ledger_entry request #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Include unit, integration tests in the code-generation to validate the models
pdp2121
reviewed
Sep 17, 2024
| bridge: | ||
| type: object | ||
| properties: | ||
| IssuingChainDoor: |
There was a problem hiding this comment.
All these fields are required for BridgeEntry
There was a problem hiding this comment.
updated in 0730767
|
Tricky part here would be to handle things like |
pdp2121
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specification borrows content from the documentation webpage: https://xrpl.org/docs/references/http-websocket-apis/public-api-methods/ledger-methods/ledger_entry#response-format
I'd like to see these issues fixed in the main documentation site. We need to update the specification after that change.
As part of future work, I'd like to add unit test to validate the correctness of these models. More importantly, unit tests are absent for all the models relevant to the current prototype specification. We need to port tests from the client libraries into the code-generation repository to make up for the deficit.