Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account_lines request schema #6

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

ckeshava
Copy link
Collaborator

@ckeshava ckeshava commented Aug 26, 2024

OpenAPI and AsyncAPI models for account_lines request

- include the AccountLinesErrorResponse
- specify account_lines RPC in other parts of the specification

TODO: include account_lines rpc in the async_api portion of the codebase
@ckeshava ckeshava changed the title [WIP] account_lines models for OpenAPI spec. account_lines request schema Aug 29, 2024
@ckeshava ckeshava marked this pull request as ready for review August 29, 2024 22:52
@ckeshava
Copy link
Collaborator Author

account_lines request does not have difference between rippled API v1 and v2. I did not find any such differences mentioned in the documentation

I used the typescript-axios generator (with the OpenAPI generator project) to generator Typescript SDK. The account_lines related code appears to have been generated correctly.

@ckeshava
Copy link
Collaborator Author

P.S.: I filed an issue report pertaining to account_lines request.

Once this bug report is addressed on the documentation website, we will need to update the specification.

Copy link
Collaborator

@pdp2121 pdp2121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckeshava
Copy link
Collaborator Author

ckeshava commented Sep 4, 2024

@pdp2121 I'll create a separate PR for ledger_entry request. Can we merge this PR first?

@ckeshava ckeshava merged commit 39d8277 into ripple:main Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants