Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use feature RPC to populate EnableAmendment tx Simple page. #1001

Open
pdp2121 opened this issue Jun 27, 2024 · 0 comments · May be fixed by #1052
Open

Use feature RPC to populate EnableAmendment tx Simple page. #1001

pdp2121 opened this issue Jun 27, 2024 · 0 comments · May be fixed by #1052
Assignees
@pdp2121
Labels
amendments enhancement New feature or request good first issue Good for newcomers

Comments

@pdp2121
Copy link
Collaborator

pdp2121 commented Jun 27, 2024

With the new feature RPC introduced in rippled 2.2.0, EnableAmendment tx Simple page can populate its data using amendment id without dependence on xrpl.org and rippled docs (which change pretty frequently):

https://github.com/ripple/explorer/blob/staging/src/containers/shared/amendmentUtils.ts

The logic would be simplified and consistency would be improved
@pdp2121 pdp2121 mentioned this issue Jun 27, 2024
Closed
@pdp2121 pdp2121 added enhancement New feature or request good first issue Good for newcomers amendments labels Jun 27, 2024
@pdp2121 pdp2121 self-assigned this Sep 4, 2024
@mvadari mvadari changed the title Use feature RPC to populate AmendmentEnable tx Simple page. Use feature RPC to populate EnableAmendment tx Simple page. Sep 19, 2024
@pdp2121 pdp2121 linked a pull request Oct 2, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdp2121 pdp2121

Labels
amendments enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use feature rpc for EnableAmendment ripple/explorer
1 participant
@pdp2121