New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the logic in `amendmentUtils.ts` with validator-history-service API for `EnableAmendment` transaction #894

Closed

pdp2121 opened this issue Dec 4, 2023 · 4 comments

Labels

good first issue

Collaborator

pdp2121 commented Dec 4, 2023

The logic in this file to populate data for EnableAmendment transactions:
https://github.com/ripple/explorer/blob/staging/src/containers/shared/amendmentUtils.ts

can be now replaced with the validator-history-service new API:
https://data.xrpl.org/v1/network/amendment/info/{amendment id/name}

For example:
https://data.xrpl.org/v1/network/amendment/info/8CC0774A3BF66D1D22E76BBDA8E8A232E6B6313834301B3B23E8601196AE6455

The text was updated successfully, but these errors were encountered:

mvadari added the good first issue label

nick2432 commented Dec 16, 2023

can i work on this?

Collaborator

mvadari commented Dec 18, 2023

can i work on this?

@nick2432 sure!

Collaborator Author

pdp2121 commented Mar 4, 2024

@nick2432 just want to check in and see if you need help on this. Thanks!

pdp2121 closed this as completed

Collaborator Author

pdp2121 commented Jun 27, 2024 •

edited

Loading

Closed this one and opened the following as an alternative (better) solution: #1001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment