Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in route groups #1881

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fixed bug in route groups #1881

wants to merge 5 commits into from

Conversation

tomasherceg
Copy link
Member

@tomasherceg tomasherceg commented Nov 3, 2024

We had several issues in route groups when used in combination with URL and route redirections:

config.RouteTable.AddGroup(
    "CmsAdmin", urlPrefix, "embedded://Shared.Infrastructure.Cms.Admin", routes =>
{
    routes.AddRouteRedirection(
        "Index", 
        "", // this URL was not concatenated with the group prefix, 
        "CmsAdmin_Articles");
    routes.Add("Preview", 
        "articles/preview", 
        "some_valid_virtual_path", // this cannot be null and requires a valid embedded resource path even though it is not used 
        presenterFactory: _ => new PreviewPopupPresenter());
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants