Fix ko.observable handling in Linq translations #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
exyi
commented
Oct 16, 2024
exyi
commented
- FirstOrDefault, LastOrDefault, ... should behave like indexers
- return observable, if the array contains observables, which then needs to be unwrapped
- this is a regression in 4.3
- Where, Order, Take, ... return the same structure which the original array has
- Select is weird as it unwraps all observables in the array, but not recursively. That's why patch adds the JsObjectObservableMap object, which can represent this mid-state (and many other combinations)
- Indexing after Select was apparently always broken in DotVVM
exyi
added a commit
that referenced
this pull request
Oct 16, 2024
This is a lighterweight alternative to #1870, which we might not want to merge to 4.3. This PR does only fixes the 4.3 regression, the problem with .Select(...).ToArray()[0] is not fixed
exyi
force-pushed
the
fix-linq-translations-observables
branch
5 times, most recently
from
43e5a18
to
562c26f
Compare
tomasherceg
approved these changes
Oct 18, 2024
* FirstOrDefault, LastOrDefault, ... should behave like indexers
- return observable, if the array contains observables, which then needs to be unwrapped
- this is a regression in 4.3
* Where, Order, Take, ... return the same structure which the original array has
* Select is weird as it unwraps all observables in the array, but not recursively. That's why patch adds the JsObjectObservableMap object, which can represent this mid-state (and many other combinations)
- Indexing after Select was apparently always broken in DotVVM
exyi
force-pushed
the
fix-linq-translations-observables
branch
from
562c26f
to
2f374f5
Compare
exyi
added a commit
that referenced
this pull request
Oct 27, 2024
This is a lighterweight alternative to #1870, which we might not want to merge to 4.3. This PR does only fixes the 4.3 regression, the problem with .Select(...).ToArray()[0] is not fixed
exyi
force-pushed
the
fix-linq-translations-observables
branch
from
2f374f5
to
79963b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.