Added wait to fix the flaky test #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasherceg
force-pushed
the
fix/redirect-flaky-test
branch
from
134bd1f
to
6df0abe
Compare
tomasherceg
force-pushed
the
fix/redirect-flaky-test
branch
from
6df0abe
to
21d62d2
Compare
exyi
approved these changes
Aug 15, 2023
commit d5a20a3 Author: Adam Štěpánek <[email protected]> Date: Tue Aug 22 12:52:24 2023 +0200 Update selenium-utils commit a6a85a7 Author: Adam Štěpánek <[email protected]> Date: Mon Aug 21 18:31:33 2023 +0200 Fix build commit e99ee7d Author: Adam Štěpánek <[email protected]> Date: Mon Aug 21 18:23:21 2023 +0200 Bump JSON commit 1ef376d Author: Adam Štěpánek <[email protected]> Date: Mon Aug 21 17:48:23 2023 +0200 Update packages commit 4d64316 Author: Adam Štěpánek <[email protected]> Date: Mon Aug 21 17:18:32 2023 +0200 CI commit f339318 Author: Adam Štěpánek <[email protected]> Date: Mon Aug 21 17:05:45 2023 +0200 Restore nuget packages using the internal feed commit 1affbe6 Author: Adam Štěpánek <[email protected]> Date: Mon Aug 21 16:59:14 2023 +0200 Fix CI commit bf353e4 Author: Adam Štěpánek <[email protected]> Date: Mon Aug 21 16:55:32 2023 +0200 Fix CI commit de657ca Author: Adam Štěpánek <[email protected]> Date: Mon Aug 21 16:51:04 2023 +0200 Try out possibly fixed version of riganti/selenium-utils
exyi
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Selenium is throwing an error when we ask for the URL during the browser navigation.
I've added a simple wait to see if it can be fixed like that.