Added extensibility point to provide custom fetch implementation #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd vote for bundling special version for the MAUI, I'd guess this might not be the last thing needed there. I don't really like adding features which will never be needed in most apps and this unnecessarily increasing the bundle size (although this isn't a large change, so whatever) |
|
I've done this as part of this draft PR #1368. Depends on #1329 which should be merged first. I've put there only the necessary things for DotVVM app to run inside WebView - the other things are still in the external repo but I plan to integrate it into DotVVM repository soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if it is a good idea to provide this extensibility point in the public API, but the attacker can replace
window.fetchanyway so it's probably not such a big deal.Alternatively, we can bundle a special version of DotVVM for the MAUI hosted version - what do you think?