Allow hardcoded values and resource bindings in IncludeInPage, Visibl…

…e properties It only produced a warning, but still, hardcoded values and resource bindings are already supported in both properties.
riganti · Aug 2, 2023 · 7ecda72 · 7ecda72
1 parent f059d47
commit 7ecda72
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/Framework/Framework/Controls/DotvvmControl.cs b/src/Framework/Framework/Controls/DotvvmControl.cs
@@ -115,7 +115,7 @@ public ClientIDMode ClientIDMode
         /// <remarks>
         /// Essentially wraps Knockout's 'if' binding.
         /// </remarks>
-        [MarkupOptions(AllowHardCodedValue = false)]
+        [MarkupOptions]
         public bool IncludeInPage
         {
             get { return (bool)GetValue(IncludeInPageProperty)!; }

diff --git a/src/Framework/Framework/Controls/HtmlGenericControl.cs b/src/Framework/Framework/Controls/HtmlGenericControl.cs
@@ -133,7 +133,7 @@ public string? InnerText
         /// <summary>
         /// Gets or sets whether the control is visible. When set to false, `style="display: none"` will be added to this control.
         /// </summary>
-        [MarkupOptions(AllowHardCodedValue = false)]
+        [MarkupOptions]
         public bool Visible
         {
             get { return (bool)GetValue(VisibleProperty)!; }

diff --git a/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json b/src/Tests/Runtime/config-tests/ConfigurationSerializationTests.SerializeDefaultConfig.json
@@ -564,8 +564,7 @@
       },
       "IncludeInPage": {
         "type": "System.Boolean",
-        "defaultValue": true,
-        "onlyBindings": true
+        "defaultValue": true
       }
     },
     "DotVVM.Framework.Controls.EmptyData": {
@@ -1016,8 +1015,7 @@
       },
       "Visible": {
         "type": "System.Boolean",
-        "defaultValue": true,
-        "onlyBindings": true
+        "defaultValue": true
       }
     },
     "DotVVM.Framework.Controls.HtmlLiteral": {