bug: fix accuracy metric and add test_with_y=True
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Thank you so much for your work on this project. I was using your script to finetune ELECTRA on a smaller dataset and noticed that the
learnerwas not reporting accuracy or validation loss. I took some time to look into it and figured out the issue on my end.The first issue was that without the
test_with_y=Trueparameter, I did not see the labels inside the examples of the validation data loader. So I have added this parameter.Second, the implementation of
accuracyin the FastAI API used in the project seems to be broken, it was throwing an error likeAttributeError: 'bool' object has no attribute 'float', so I have added code to cast the two tensors. I'm not sure this is the best way to do this but it worked for me.Thanks again for your work