GNU Parallel Semaphores Added #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First go ahead with semaphores for LMD. Using GNU's parallel program (perl
threads with file locking) we are able to parallelize the file scanning
process which is the bottleneck in this process.
Users can pass in the number of threads at run by the -a param:
maldet -a /home/?/public_html 15
This will run 15 thread scans.....^^
With one test case pass, I suspect more bugs exists in this implementation. So
far that one test cases includes scanning the /tmp directory where no hits
were found. In addition, the test case was not branch coverage so some if /
logic statements were never ran.
The downfall of using semaphores within bash is variable scope -- they need to
be exported into the environment. This is where most bugs will be introduced.
Signed-off-by: Adam Brenner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First go ahead with semaphores for LMD. Using GNU's parallel program (perl
threads with file locking) we are able to parallelize the file scanning
process which is the bottleneck in this process.
Users can pass in the number of threads at run by the -a param:
maldet -a /home/?/public_html 15
This will run 15 thread scans.....^^
With one test case pass, I suspect more bugs exists in this implementation. So
far that one test cases includes scanning the /tmp directory where no hits
were found. In addition, the test case was not branch coverage so some if /
logic statements were never ran.
The downfall of using semaphores within bash is variable scope -- they need to
be exported into the environment. This is where most bugs will be introduced.
Signed-off-by: Adam Brenner [email protected]