parallelized lipidblast and reads more info #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorainer
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Thanks for the contribution @pratarora ! Code looks great, I will then fix the unit tests after merging.
Can you however please add yourself as a contributor (role = c("ctb")) to the DESCRIPTION file and to the @author tag of the compound_tbl_lipidblast()` function?
jorainer
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Thanks @pratarora ! Will merge and then push to Bioconductor
|
@pratarora , hope it's OK, but I added you also as a contributor to the RforMassSpectrometry page |
|
Thanks a lot, @jorainer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed compound_tbl_lipidblast and dependent function to allow it to read more information from the json files,and parallelized it to allow faster reading.
I have tested it on old and new lipidblast as described in #114
Best regards
Prateek