Fix S3Boto3Storage backend and test cases #415
Conversation
| try: | ||
| storage = self.get_storage() | ||
| storage.delete(file_name) | ||
| except Exception as e: | ||
| raise ServiceUnavailable("File was not deleted") from e |
There was a problem hiding this comment.
Somehow I have a few question around this design.
What do you think of the other design:
if not storage.exists(file_name):
raise ServiceUnavailable("File does not exist")...since, ServiceUnavailable is already a well-defined exception.
There was a problem hiding this comment.
good catch! i'll change that!
There was a problem hiding this comment.
have another look @50-Course if you like!
|
Hello, everyone! 😊 Do you have estimate of when this fix will be available, please? |
|
Hello, guys! I think this PR is very important because this error invalidate the purpose of package. Please, merge this PR if is done. Thanks! |
I can only second that! |
|
Looks like there is a linting error, if you can correct that I'll get this merged. Thanks! |
|
I've attempted to resolve the isort error and believe it should be fixed now. However, I'm currently unable to initiate GitHub Actions to confirm if the continuous integration (CI) checks are successful. |
|
@frankwiles i think i have it now. actions are now successul on my fork. |
|
@frankwiles could you please have a look? thanks alot! |
|
Hello guys, some news for this PR? @frankwiles @krystofbe |
|
@victoraugusto6 my work is done, but this needs to be merged by a member of revsys. |
|
Just reaching out because I'm a bit bummed about the delay in getting my pull request merged. It's a critical fix for the S3Boto3StorageHealthCheck, and I know it's important for folks using the I've put a lot of work into this, and it feels like we're leaving users in the lurch by not rolling it out. I'm considering forking the project and pushing the fix to PyPI if we can't get it merged here soon. Really don't want to go down that road, but I want to make sure users have what they need. Can we get some movement on this? |
|
Sorry for the delay in getting to this and thanks for fixing it! |
Fix for
S3Boto3StorageHealthCheckFailure in Version 3.18.0Problem Description
After upgrading from
django-health-checkversion 3.17.0 to 3.18.0, several users have reported failures with theS3Boto3StorageHealthCheck. This issue appears to stem fromself.storage_aliasbeingNonewhen it is used within theS3Boto3StorageHealthCheck, leading to anAttributeErrorwhen the code attempts to call thesavemethod on aNoneTypeobject. This behavior was not observed in version 3.17.0 and has been consistently reproducible in version 3.18.0.Additional Notes
This fix aims to restore the expected functionality of the S3Boto3StorageHealthCheck without altering the behavior of other storage health checks. Feedback and further testing are welcome to ensure comprehensive coverage and resolution of the issue.