Fix compatibility with pre-3.18 custom check backends #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `subset` parameter added to `BaseHealthCheckBackend`'s `run_check` and `check_status` methods in 4da1fd9 broke compatibility with existing custom check backends, since they don't accept this parameter. Moreover, this parameter appears to be entirely useless, since `check_status` is only called by `run_check`, and `run_check` is only called by `CheckMixin.run_check`, which never passed a value for `subset`. Get rid of it and restore compatibility.
|
Thanks for this! Great catch, not sure how we missed this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
subsetparameter added toBaseHealthCheckBackend'srun_checkandcheck_statusmethods in 4da1fd9 broke compatibility with existing custom check backends, since they don't accept this parameter.Moreover, this parameter appears to be entirely useless, since
check_statusis only called byrun_check, andrun_checkis only called byCheckMixin.run_check, which never passed a value forsubset.Get rid of it and restore compatibility.
Fixes #413.