Skip to content

Commit

Permalink
Remove '?.' syntax from driver (#4)
Browse files Browse the repository at this point in the history
* Remove '?.' syntax from driver

* Align versioning with tag names

* Change asset upload module
  • Loading branch information
bruwozniak authored Nov 2, 2020
1 parent 13e2d82 commit 003961e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 13 deletions.
14 changes: 3 additions & 11 deletions .github/workflows/extension.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Exasol SQLTools Driver

on:
Expand Down Expand Up @@ -39,12 +36,7 @@ jobs:
draft: false
prerelease: false
- name: Upload Release Asset
id: upload-release-asset
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
uses: AButler/[email protected]
with:
upload_url: ${{ steps.create_release.outputs.upload_url }} # This pulls from the CREATE RELEASE step above, referencing it's ID to get its outputs object, which include a `upload_url`. See this blog post for more info: https://jasonet.co/posts/new-features-of-github-actions/#passing-data-to-future-steps
asset_path: exasol-driver-${{ github.ref }}.vsix
asset_name: exasol-driver-${{ github.ref }}.vsix
asset_content_type: application/zip
files: 'exasol-driver-*.vsix'
repo-token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "exasol-driver",
"displayName": "Exasol Driver",
"description": "Exasol Driver for SQLTools",
"version": "0.0.1",
"version": "0.0.2",
"engines": {
"vscode": "^1.42.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/ls/driver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export default class YourDriverClass extends AbstractDriver<DriverLib, DriverOpt
case ContextValue.VIEW:
return this.queryResults(this.queries.searchTables({ search }));
case ContextValue.COLUMN:
if (_extraParams.tables?.length > 0) {
if (_extraParams.tables && _extraParams.tables.length > 0) {
return this.queryResults(this.queries.searchColumns({ search, tables: _extraParams.tables || [] }));
} else {
return [];
Expand Down

0 comments on commit 003961e

Please sign in to comment.