feat: include replies in copied text #285
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ran into some formatting issues with solid components so i figured i'd put all the logic into its own function instead. i think it ends up being much more readable as a result anyway, but i can revert it if solid components would be preferred. aside from that, im also wondering if i should just expand to PR to fix copy text in general since there seems to be a number of issues outside of just missing the "replying to" text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure to check the following tasks before opening and submitting a PR
this PR will resolve #172
currently a draft while i sort out some edge cases and locale stuff, but the basic functionality is there already.