Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete test #34

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: delete test #34

wants to merge 6 commits into from

Conversation

christophehurpeau
Copy link
Member

@christophehurpeau christophehurpeau commented Jun 28, 2020 •
edited by reviewflow-dev bot
Loading

Context

Explain here why this PR is needed

Solution

If needed, explain here the solution you chose for this

@christophehurpeau christophehurpeau changed the title Delete test Delete test Jun 28, 2020
@reviewflow-dev
Copy link

reviewflow-dev bot commented Jun 28, 2020 •
edited
Loading

Options:

  • This PR is a feature branch
  • Add [skip ci] on merge commit
  • Auto merge when this PR is ready and has no failed statuses. (Also has a queue per repo to prevent multiple useless "Update branch" triggers)
  • Automatic branch delete after this PR is merged

@christophehurpeau christophehurpeau changed the title Delete test Delete test Jul 5, 2020
@reviewflow-dev reviewflow-dev bot changed the title Delete test Delete test Jul 5, 2020
@reviewflow-dev reviewflow-dev bot added 👌 code/needs-review Synced by reviewflow for code/needs-review 👌 code/review-requested Synced by reviewflow for code/review-requested labels Jan 21, 2021
@reviewflow-dev reviewflow-dev bot added 👌 code/approved Synced by reviewflow for code/approved and removed 👌 code/needs-review Synced by reviewflow for code/needs-review 👌 code/review-requested Synced by reviewflow for code/review-requested labels Jan 21, 2021
@chris-reviewflow chris-reviewflow self-requested a review January 21, 2021 22:16
@reviewflow-dev reviewflow-dev bot added 👌 code/needs-review Synced by reviewflow for code/needs-review 👌 code/review-requested Synced by reviewflow for code/review-requested and removed 👌 code/approved Synced by reviewflow for code/approved labels Jan 21, 2021
@christophehurpeau christophehurpeau force-pushed the christophehurpeau-patch-4 branch 2 times, most recently from c13150f to faf259c Compare September 5, 2022 21:47
@reviewflow-dev
Copy link

reviewflow-dev bot commented Sep 5, 2022 •
edited
Loading

Progress

☑️ Step 1: ✏️ Write code
☑️ Step 2: 💚 Checks
⬜ Step 3: 👌 Code Review
⬜ Step 4: 🚦 Merge Pull Request

Options:

  • 🚦 automerge: Automatically merge when this PR is ready and has no failed statuses. When the repository requires branches to be up to date before merging, it merges default branch, with a queue per repo to prevent multiple merges when several PRs are ready. A fail job prevents the merge.
  • 🚦 skip-ci: Add [skip ci] on merge commit when merge is done with autoMerge.
  • ♻️ Automatically delete the branch after this PR is merged. (⚠️ Legacy Option: Delete branch with Github Setting)

Actions:

  • 🐛 Force updating reviewflow checks for this PR. Use this to try to fix reviewflow checks that are still missing/pending, which might happen if webhook failed or something bad happened when reviewflow tried to send the status check to github.
  • 🔄 update branch: Merge base branch in this PR's branch. Only works if merging is possible without conflicts.

@christophehurpeau christophehurpeau force-pushed the christophehurpeau-patch-4 branch 3 times, most recently from 21e9c2e to 22aa598 Compare September 5, 2022 21:51
@reviewflow-dev
Copy link

reviewflow-dev bot commented Sep 5, 2022

@christophehurpeau : Force-pushing is a bad practice

@christophehurpeau christophehurpeau force-pushed the christophehurpeau-patch-4 branch from 22aa598 to 73a53ce Compare September 5, 2022 21:59
@reviewflow-dev
Copy link

reviewflow-dev bot commented Sep 5, 2022

@christophehurpeau : Force-pushing is a bad practice

chris-reviewflow
chris-reviewflow requested changes Sep 5, 2022
View reviewed changes
Copy link
Collaborator

@chris-reviewflow chris-reviewflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nok

@reviewflow-dev reviewflow-dev bot added 👌 code/changes-requested Synced by reviewflow for code/changes-requested and removed 👌 code/review-requested Synced by reviewflow for code/review-requested labels Sep 5, 2022
@christophehurpeau christophehurpeau force-pushed the christophehurpeau-patch-4 branch 2 times, most recently from 06ca1cc to bdf0895 Compare September 5, 2022 22:00
@reviewflow-dev reviewflow-dev bot added 💚 checks/fail Synced by reviewflow for checks/failed and removed 💚 checks/passed Synced by reviewflow for checks/passed labels Jul 9, 2023
@christophehurpeau christophehurpeau changed the title delete test feat: delete test Jul 9, 2023
@reviewflow-dev reviewflow-dev bot added 💚 checks/passed Synced by reviewflow for checks/passed and removed 💚 checks/fail Synced by reviewflow for checks/failed labels Jul 9, 2023
@reviewflow-dev reviewflow-dev bot added 💚 checks/passed Synced by reviewflow for checks/passed and removed 💚 checks/passed Synced by reviewflow for checks/passed labels Jul 9, 2023
@reviewflow-dev reviewflow-dev bot removed the 💚 checks/passed Synced by reviewflow for checks/passed label Jul 9, 2023
@christophehurpeau christophehurpeau changed the title feat: delete test delete test Jul 9, 2023
@reviewflow-dev reviewflow-dev bot added the 💚 checks/fail Synced by reviewflow for checks/failed label Jul 9, 2023
@reviewflow-dev reviewflow-dev bot added 💚 checks/fail Synced by reviewflow for checks/failed and removed 💚 checks/fail Synced by reviewflow for checks/failed labels Jul 9, 2023
@reviewflow-dev reviewflow-dev bot added 💚 checks/fail Synced by reviewflow for checks/failed and removed 💚 checks/fail Synced by reviewflow for checks/failed labels Jul 9, 2023
@christophehurpeau christophehurpeau changed the title delete test feat: delete test Jul 9, 2023
@christophehurpeau christophehurpeau changed the title feat: delete test delete test Jul 9, 2023
@christophehurpeau christophehurpeau changed the title delete test feat: delete test Jul 9, 2023
@christophehurpeau christophehurpeau changed the title feat: delete test delete test Jul 9, 2023
@christophehurpeau christophehurpeau changed the title delete test feat: delete test Jul 9, 2023
@christophehurpeau christophehurpeau changed the title feat: delete test delete test Jul 9, 2023
@reviewflow-dev reviewflow-dev bot added 💚 checks/fail Synced by reviewflow for checks/failed and removed 💚 checks/fail Synced by reviewflow for checks/failed labels Jul 9, 2023
@christophehurpeau christophehurpeau changed the title delete test feat: delete test Jul 9, 2023
@reviewflow-dev reviewflow-dev bot added 💚 checks/passed Synced by reviewflow for checks/passed and removed 💚 checks/fail Synced by reviewflow for checks/failed labels Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-reviewflow chris-reviewflow chris-reviewflow requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
💚 checks/passed Synced by reviewflow for checks/passed 👌 code/changes-requested Synced by reviewflow for code/changes-requested 👌 code/needs-review Synced by reviewflow for code/needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophehurpeau @chris-reviewflow