Improve metadata saving logic in Item properties and Filter panel #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the prefix for some static class members from `g_` to `s_` in line with current conventions in the project.
This makes how metadata changes are saved in Item properties consistent with how they are saved in the playlist view. This includes sharing more logic and pushing more logic to the `file_info_filter` implementation.
This makes how metadata changes are saved in Item properties more consistent with how they are saved in the playlist view and Item properties. This is by pushing more logic to the `file_info_filter` implementation.
reupen
force-pushed
the
inline-editing-implementation
branch
from
414e283 to
555ab60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the way Item properties and Filter panel write metadata changes when using inline editing more consistent with the playlist view.
In particular, more logic is pushed to the
file_info_filterclass. This should also improve safety, as it causes changes to be applied to freshly read metadata, rather than the cached copy.Some code was cleaned up at the same time.