Add support for Ctrl-Tab to Playlist tabs and Tab stack #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for using Ctrl-Tab and Shift-Ctrl-Tab to switch tabs in the Playlist tabs and Tab stack panels. This wasn't straightforward to implement; both component have little control over the contents of children, and can also contain nested tabs. Nonetheless, this solution should handle most scenarios well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #146
This adds support for using Ctrl-Tab and Shift-Ctrl-Tab to switch tabs in the Playlist tabs and Tab stack panels.
This wasn't straightforward to implement; both component have little control over the contents of children, and can also contain nested tabs. Nonetheless, this solution should handle most scenarios well.
Additionally, the existing code to update the keyboard focus when switching tabs in the Tab stack wasn't working correctly. This has been fixed as part of this, and the focus is now set to the first focusable element in the new tab (unless the tabs themselves were previously focused, or the new tab doesn't have any focusable children).