Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: angular 18 #53

Merged
merged 1 commit into from
Sep 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
fail-fast: false
max-parallel: 2
matrix:
version: [17,16,15,14,13,12]
version: [18,17,16,15,14,13,12]
uses: ./.github/workflows/regression.yml
with:
name: angular
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@
"globals": "^15.9.0",
"nodemon": "^2.0.20",
"rete-cli": "~2.0.1",
"rete-kit": "^1.9.2",
"rete-kit": "^1.10.0",
"typescript": "^4.9.5"
},
"peerDependencies": {
"rete-kit": "^1.9.2"
"rete-kit": "^1.10.0"
},
"dependencies": {
"@playwright/test": "^1.37.1",
Expand Down
4 changes: 2 additions & 2 deletions src/commands/init/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
export const targets: { stack: App.AppStack, versions: number[] }[] = [
{ stack: 'react', versions: [16, 17, 18] },
{ stack: 'vue', versions: [2, 3] },
{ stack: 'angular', versions: [12, 13, 14, 15, 16, 17] },
{ stack: 'angular', versions: [12, 13, 14, 15, 16, 17, 18] },
{ stack: 'svelte', versions: [3, 4] },
{ stack: 'lit-vite', versions: [3] }
]
Expand All @@ -20,11 +20,11 @@

export function getFeatures({ stack, version }: Pick<(typeof fixtures)[0], 'stack' | 'version'>, next: boolean) {
return [
stack === 'angular' && new App.Features.Angular(version as 12 | 13 | 14 | 15, next),
stack === 'angular' && new App.Features.Angular(version as 12 | 13 | 14 | 15 | 16 | 17 | 18, next),

Check warning on line 23 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / ci / ci

The 'version as 12 | 13 | 14 | 15 | 16 | 17 | 18' has unsafe 'as' type assertion
stack === 'react' && new App.Features.React(version, stack, next),
stack === 'vue' && new App.Features.Vue(version as 2 | 3, next),

Check warning on line 25 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / ci / ci

The 'version as 2 | 3' has unsafe 'as' type assertion
stack === 'svelte' && new App.Features.Svelte(version as 3 | 4, next),

Check warning on line 26 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / ci / ci

The 'version as 3 | 4' has unsafe 'as' type assertion
stack === 'lit-vite' && new App.Features.Lit(version as 3, next),

Check warning on line 27 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / ci / ci

The 'version as 3' has unsafe 'as' type assertion
new App.Features.ZoomAt(),
new App.Features.OrderNodes(),
new App.Features.Dataflow(next),
Expand All @@ -35,7 +35,7 @@
}

export function validate(stacks: string[], stackVersions: string[] | null): { error: string | null } {
const unknownStacks = stacks.filter(name => !stackNames.includes(name as App.AppStack))

Check warning on line 38 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / ci / ci

The 'name as App.AppStack' has unsafe 'as' type assertion

if (unknownStacks.length > 0) {
return { error: `Unknown stack names: ${unknownStacks.join(', ')}` }
Expand Down
Loading