Skip to content

Commit

Permalink
Merge pull request #54 from retejs/ci-change-react-builder
Browse files Browse the repository at this point in the history
React vite
  • Loading branch information
Ni55aN authored Dec 27, 2024
2 parents 96338d0 + 8ea30ee commit 7b734fa
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
version: [18,17,16]
uses: ./.github/workflows/regression.yml
with:
name: react
name: react-vite
version: ${{ matrix.version }}
node: 18

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ on:
description: Stack
options:
- react
- react-vite
- vue
- angular
- svelte
Expand Down
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"globals": "^15.9.0",
"nodemon": "^2.0.20",
"rete-cli": "~2.0.1",
"rete-kit": "^1.10.0",
"rete-kit": "^1.10.2",
"typescript": "^4.9.5"
},
"peerDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion src/commands/init/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { App } from 'rete-kit'

export const targets: { stack: App.AppStack, versions: number[] }[] = [
{ stack: 'react', versions: [16, 17, 18] },
{ stack: 'react-vite', versions: [16, 17, 18] },
{ stack: 'vue', versions: [2, 3] },
{ stack: 'angular', versions: [12, 13, 14, 15, 16, 17, 18] },
{ stack: 'svelte', versions: [3, 4] },
Expand All @@ -21,7 +22,7 @@ export const fixtures = targets
export function getFeatures({ stack, version }: Pick<(typeof fixtures)[0], 'stack' | 'version'>, next: boolean) {
return [
stack === 'angular' && new App.Features.Angular(version as 12 | 13 | 14 | 15 | 16 | 17 | 18, next),

Check warning on line 24 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / release / publish

The 'version as 12 | 13 | 14 | 15 | 16 | 17 | 18' has unsafe 'as' type assertion
stack === 'react' && new App.Features.React(version, stack, next),
['react', 'react-vite'].includes(stack) && new App.Features.React(version, stack, next),
stack === 'vue' && new App.Features.Vue(version as 2 | 3, next),

Check warning on line 26 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / release / publish

The 'version as 2 | 3' has unsafe 'as' type assertion
stack === 'svelte' && new App.Features.Svelte(version as 3 | 4, next),

Check warning on line 27 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / release / publish

The 'version as 3 | 4' has unsafe 'as' type assertion
stack === 'lit-vite' && new App.Features.Lit(version as 3, next),

Check warning on line 28 in src/commands/init/index.ts

View workflow job for this annotation

GitHub Actions / release / publish

The 'version as 3' has unsafe 'as' type assertion
Expand Down
3 changes: 1 addition & 2 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ program
.option('-s --stack <stack>', `Stacks to test, comma-separated (${stackNames.join(',')})`)
.option('-sv --stack-versions <stack-version>', `Versions to test, comma-separated`)
.action(async (options: { depsAlias: string, stack?: string, stackVersions?: string, next?: boolean }) => {

Check warning on line 26 in src/index.ts

View workflow job for this annotation

GitHub Actions / release / publish

Async arrow function has too many statements (26). Maximum allowed is 16
if (!process.version.startsWith('v16')) console.info(chalk.yellow('---\nWe recommend using Node.js 16 to avoid any potential issues\n---'))

const next = options.next || false
const cwd = process.cwd()
const depsAlias = options.depsAlias
Expand Down Expand Up @@ -130,6 +128,7 @@ program
log('success', 'START')('Testing in', chalk.yellow(folder), '...')
const APP = folder
const SERVE = App.builders[stack].getStaticPath(folder, version)
console.log({ SERVE })
const playwrightFolder = dirname(require.resolve('@playwright/test'))

const { error } = await validateTestRun(APP, SERVE)
Expand Down

0 comments on commit 7b734fa

Please sign in to comment.