Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle trailing slashes on root route and avoid crashes due to AssertionErrors thrown by odd requests #1960

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: handle trailing slashes on root route and avoid crashes due to AssertionErrors thrown by odd requests #1960

wants to merge 5 commits into from

Commits on Jul 3, 2023

  1. add failing test originally authored by @mridgway

    @nexdrew
    nexdrew committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    3562205 View commit details
    Browse the repository at this point in the history

  2. use root when stripped to empty string

    @nexdrew
    nexdrew committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    20fab3e View commit details
    Browse the repository at this point in the history

  3. add failing test for defaultRoute with null pathname

    @nexdrew
    nexdrew committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    fd5ec1f View commit details
    Browse the repository at this point in the history

  4. add failing test for router.lookup with null pathname

    @nexdrew
    nexdrew committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    7e6fab4 View commit details
    Browse the repository at this point in the history

  5. handle null pathname in router methods

    @nexdrew
    nexdrew committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    606f735 View commit details
    Browse the repository at this point in the history