Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a railtie to load rescue scheduler automatically in rails apps #694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josh-m-sharpe
Copy link

Should eliminate some basic boilerplating.

Copy link
Contributor

@iloveitaly iloveitaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you:

  • Rebase on master so CI runs
  • Add a note to the changelog
  • Update the readme?

Thanks!

@@ -8,6 +8,8 @@
require_relative 'scheduler/signal_handling'
require_relative 'scheduler/failure_handler'

require 'resque/scheduler/railtie' if defined?(Rails)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the issue that came up in resque I think we need to do

Suggested change
require 'resque/scheduler/railtie' if defined?(Rails)
require 'resque/scheduler/railtie' if defined?(Rails::Railtie)

Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants