-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PA and IN lower gov #243
base: main
Are you sure you want to change the base?
PA and IN lower gov #243
Conversation
states/IN/lower_dem.yaml
Outdated
|
||
- visit: "https://indianahousedemocrats.org/members/vernon-smith/full#form_individual-member-contact" | ||
- fill_in: | ||
- name: full_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix tabbing.
states/IN/lower_dem.yaml
Outdated
|
||
#Skipped the file upload section | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove. (We know we're not uploading any files.)
states/IN/lower_dem.yaml
Outdated
value: $SUBJECT | ||
required: true | ||
- name: message | ||
selector: "input[name=message]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selector is textarea
states/IN/lower_dem.yaml
Outdated
- name: subject_line | ||
selector: "input[name=subject_line]" | ||
value: $SUBJECT | ||
required: true | ||
- name: message | ||
selector: "input[name=message]" | ||
value: $MESSAGE | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix tabbing
states/IN/lower_dem.yaml
Outdated
- name: g-recaptcha-response | ||
selector: '#g-recaptcha-response' | ||
value: $CAPTCHA_SOLUTION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessary. Generally, only the 'recaptcha' directive is required. There are some rare circumstances when we have to issue instructions on the recaptchas.
states/IN/lower_dem.yaml
Outdated
- recaptcha: | ||
- value: true | ||
|
||
success: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix tabbing. (Should be in line with "steps:")
states/IN/lower_dem.yaml
Outdated
- click_on: | ||
- value: "button[class='button']" | ||
- recaptcha: | ||
- value: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move captcha above the final button click. (We need to solve the captcha before we click the button to submit the form.)
states/IN/lower_dem.yaml
Outdated
- click_on: | ||
- value: "button[class='button']" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things here - First, you want a 'selector' directive to target the element. Second, there are three buttons on the page defined like this. if you use "button[class='button']" it will click the first button that matches that selector, which is higher on the page and not the one you are looking for. You'll have to include additional attributes as part of the selector to hit the right button. Give it a try!
Replace PR for PA and IN reps forms