Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unique name for events and doctype parameter alone is redundant #2903

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Ninad1306
Copy link
Contributor

@Ninad1306 Ninad1306 commented Dec 23, 2024

@Ninad1306 Ninad1306 requested a review from ljain112 December 23, 2024 12:17
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.15%. Comparing base (5f227b2) to head (23e9412).

Files with missing lines Patch % Lines
...ndia_compliance/gst_india/utils/gstr_2/__init__.py 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2903   +/-   ##
========================================
  Coverage    60.15%   60.15%           
========================================
  Files          122      122           
  Lines        12063    12063           
========================================
  Hits          7256     7256           
  Misses        4807     4807           
Files with missing lines Coverage Δ
...gst_india/doctype/gst_return_log/gst_return_log.py 25.46% <ø> (ø)
...iance/gst_india/doctype/gstr_1_beta/gstr_1_beta.py 0.00% <ø> (ø)
...econciliation_tool/purchase_reconciliation_tool.py 24.46% <ø> (ø)
...mpliance/gst_india/utils/gstr_1/gstr_1_download.py 22.64% <ø> (ø)
india_compliance/gst_india/utils/gstr_2/gstr.py 89.55% <ø> (ø)
...ndia_compliance/gst_india/utils/gstr_2/__init__.py 62.01% <25.00%> (ø)

Impacted file tree graph

@Ninad1306 Ninad1306 requested a review from ljain112 December 26, 2024 09:29
@ljain112 ljain112 self-assigned this Dec 26, 2024
@ljain112 ljain112 added the p1 label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants