Skip to content

Commit

Permalink
Add sourcelink to enable source debugging of the nuget package (#4)
Browse files Browse the repository at this point in the history
Add sourcelink to enable source debugging of the nuget package

Remove SonarQube analysis from build
- I've tried hard with SonarQube, but its just too annoying to use

Fix the code coverage in the build. There were two problems, 
- "nuget restore" wasn't working properly, so switched to dotnet restore
- I had to use `-register:Path64` argument for opencover. I'm not sure why, as `-register:User` used to work, and is supposed to do so without admin permissions.
  • Loading branch information
ceddlyburge authored Jan 6, 2020
1 parent 940fbed commit 494ac48
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 1,038 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ A C# library for strongly typed Configuration with validation

[![Build status](https://ci.appveyor.com/api/projects/status/oujy1v19iwdba8e5?svg=true)](https://ci.appveyor.com/project/RESSoftwareTeam/configuration)

[![Quality gate](https://sonarcloud.io/api/project_badges/quality_gate?project=res.configuration)](https://sonarcloud.io/dashboard?id=res.configuration)

[![codecov](https://codecov.io/gh/resgroup/configuration/branch/master/graph/badge.svg)](https://codecov.io/gh/resgroup/configuration)

Example Usage (`Configuration` is the class provided by this repo)
Expand Down
4 changes: 2 additions & 2 deletions RES.Configuration.Test/RES.Configuration.Test.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
<BaseOutputPath>..\BuiltDLLs\</BaseOutputPath>
<ProjectGuid>40b5b4a7-ad9a-4cec-b1cf-059482dfb9ce</ProjectGuid>
<!-- only required for sonar qube, and only until they fix a .net core type issue https://jira.sonarsource.com/browse/SONARMSBRU-167 -->
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<PropertyGroup>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<DebugSymbols>True</DebugSymbols>
<WarningsAsErrors />
<NoWarn>1701;1702;1705;1125</NoWarn>
</PropertyGroup>
Expand Down
Loading

0 comments on commit 494ac48

Please sign in to comment.