-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Missing AsciiDoc Blockquotes to Markdown Editor #7390
base: main
Are you sure you want to change the base?
Conversation
BPowell76
commented
Oct 16, 2024
- Added missing "Tip" and "Caution" blockquotes to Markdown editor that are present in the AsciiDoc editor.
- Modified some Markdown-specific blockquote styling in default style to better match the styling of AsciiDoc pages.
- Fixed inconsistencies in AsciiDoc editor blockquote titles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, the 'success' blockquote from Markdown should be ported across to AsciiDoc.
I'll look into it again. I couldn't find where the asciidoc styles were coming from. Asciidoc in general, though, doesn't natively support |
I'm still checking this out, but I'm currently stumped finding out where the admonition css class is being set. Once I can figure that out I believe everything will be in parity. |
…o fix corner radii not rendering
…or.js currently doesn't support inline extensions on paragraph content
I have finished working to get When you click on the [SUCCESS]
There is a new file: |
…d corners. Updated rest of admonition block styles to explicitly set the background color to transparent Signed-off-by: Brian Powell Jr <[email protected]>
7c72235
to
32750e0
Compare
@NGPixel I know you're a busy person, but could you review this when you have a moment. I'd like to have this merged in for use in the sites I have wiki.js deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I was just thinking, since this is a feature improvement should I close this PR and recreate it for the Vega branch? |