Mark prettier as supporting range formatting #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradymadden97
requested review from
cdmistman
and removed request for
a team and
cdmistman
airportyh
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Right now we hack this in on the frontend. But ideally this would be defined by the nixmodule and flow through.
I'll need to make a proto change to pass this from goval --> web. This is assuming it's safe to add new members here prior to making the goval change.
Describe what prompted you to make this change, link relevant resources
What changed
Describe what changed to a level of detail that someone with no context with your PR could be able to review it
Test plan
Describe what you did to test this change to a level of detail that allows your reviewer to test it
Rollout
Describe any procedures or requirements needed to roll this out safely (or check the box below)