Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bun + sveltekit = <3 #105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bun + sveltekit = <3 #105

wants to merge 2 commits into from

Conversation

cdmistman
Copy link
Contributor

Why

i like bun

i like sveltekit

i like bun and sveltekit

they're better together <3

What changed

added new bun-sveltekit module

Test plan

  • install in sveltekit template
  • things still work

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

@cdmistman cdmistman marked this pull request as ready for review September 15, 2023 20:58
@cdmistman cdmistman requested a review from a team as a code owner September 15, 2023 20:58
@cdmistman cdmistman requested review from masad-frost and removed request for a team September 15, 2023 20:58
@cdmistman cdmistman force-pushed the cad/bun+sveltekit branch 2 times, most recently from 13e1aa9 to 4e40001 Compare September 15, 2023 21:00
@masad-frost
Copy link
Member

we should lean on bun create in this case and templates

masad-frost
masad-frost approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@masad-frost masad-frost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misread what this is doing. :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@masad-frost masad-frost masad-frost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdmistman @masad-frost @ryantm