Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have makefile detect src code changes #1623

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

have makefile detect src code changes #1623

wants to merge 2 commits into from

Conversation

adamancini
Copy link
Member

@adamancini adamancini commented Sep 25, 2024 •
edited
Loading

Description, Motivation and Context

Please include a summary of the change or what problem it solves. Please also include relevant motivation and context.

Add dependencies to the makefile recipes to build support-bundle binaries. Makefile should now detect changes correctly, so make watchrsync can re-build and re-rsync binaries on changes correctly.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@adamancini adamancini requested a review from a team as a code owner September 25, 2024 18:21
@adamancini adamancini added type::bug Something isn't working type::chore and removed type::bug Something isn't working labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adamancini