Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return ssh port and endpoint for direct connection #451

Merged
merged 2 commits into from
Oct 23, 2024
Merged

return ssh port and endpoint for direct connection #451

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a57067
return ssh port and endpoint for direct connection
jdewinne Oct 21, 2024
8abf9cf
rename ssh_port to direct_ssh_port
jdewinne Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/types/vm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ type VM struct {

EstimatedCost int64 `json:"estimated_cost"` // Represents estimated credits for this vm based on the TTL

OverlayEndpoint string `json:"overlay_endpoint,omitempty"`
OverlayToken string `json:"overlay_token,omitempty"`
SSHPort int64 `json:"ssh_port,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i understand now. we should maybe rename this to "direct ssh port" or something, since we will have a more supported ssh endpoint via CMX forwarder

SSHEndpoint string `json:"ssh_endpoint,omitempty"`

Tags []Tag `json:"tags"`
}
Expand Down
Loading