Merge pull request #301 from replicatedhq/no-cli-defaults

Do not apply defaults in the CLI
replicatedhq · Aug 4, 2023 · 120b904 · 120b904
2 parents a6ba951 + 02fe6cb
commit 120b904
Showing 1 changed file with 0 additions and 27 deletions.
diff --git a/pkg/kotsclient/cluster_create.go b/pkg/kotsclient/cluster_create.go
@@ -39,34 +39,7 @@ type ValidationError struct {
 	SupportedDistributions map[string][]string `json:"supported_distributions"`
 }
 
-var defaultCreateClusterOpts = CreateClusterOpts{
-	Name:                   "",
-	KubernetesDistribution: "kind",
-	KubernetesVersion:      "v1.25.3",
-	NodeCount:              int(1),
-	DiskGiB:                int64(50),
-	TTL:                    "2h",
-	InstanceType:           "",
-}
-
 func (c *VendorV3Client) CreateCluster(opts CreateClusterOpts) (*types.Cluster, *ValidationError, error) {
-	// merge opts with defaults
-	if opts.KubernetesDistribution == "" {
-		opts.KubernetesDistribution = defaultCreateClusterOpts.KubernetesDistribution
-	}
-	if opts.KubernetesVersion == "" {
-		opts.KubernetesVersion = defaultCreateClusterOpts.KubernetesVersion
-	}
-	if opts.NodeCount == int(0) {
-		opts.NodeCount = defaultCreateClusterOpts.NodeCount
-	}
-	if opts.DiskGiB == int64(0) {
-		opts.DiskGiB = defaultCreateClusterOpts.DiskGiB
-	}
-	if opts.TTL == "" {
-		opts.TTL = defaultCreateClusterOpts.TTL
-	}
-
 	reqBody := &CreateClusterRequest{
 		Name:                   opts.Name,
 		KubernetesDistribution: opts.KubernetesDistribution,