Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nginx #653

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Update Nginx #653

merged 4 commits into from
Oct 18, 2024

Conversation

dydx
Copy link
Member

@dydx dydx commented Oct 17, 2024

  • Builds nginx version 1.24.0 from source rather than installing from outdated APT or trying to update python:2 to python:3
  • Removes EOL version of remote docker in CircleCI

Locally, I can now see that nginx version: nginx/1.24.0 is installed and that it responds when spun up:

$> docker run --rm -it ttl.sh/replicated/replicated-installer:1h bash -c "nginx -v"

nginx version: nginx/1.24.0
[Fri Oct 18 17:53:06 2024] GET /healthz => generated 0 bytes in 26 msecs (HTTP/1.1 200) 2 headers in 78 bytes (1 switches on core 0)
[Fri Oct 18 17:53:10 2024] GET /livez => generated 7963 bytes in 51 msecs (HTTP/1.1 200) 2 headers in 90 bytes (1 switches on core 0)
[Fri Oct 18 17:53:18 2024] GET /stable => generated 60511 bytes in 59 msecs (HTTP/1.1 200) 2 headers in 91 bytes (2 switches on core 0)
[Fri Oct 18 17:53:20 2024] GET /kubernetes-images.json => generated 1113 bytes in 6 msecs (HTTP/1.1 200) 2 headers in 73 bytes (1 switches on core 0)
[Fri Oct 18 17:53:24 2024] GET /kubernetes-images.json => generated 1113 bytes in 9 msecs (HTTP/1.1 200) 2 headers in 73 bytes (2 switches on core 0)

And it appears that builds / tests succeed. Since the standard PR workflow does not actually build Dockerfile.prod, I temporarily placed that Job in the Workflow to see that it would build correctly in CircleCI

Screenshot 2024-10-17 at 23 02 09

@dydx dydx self-assigned this Oct 17, 2024
@dydx dydx requested review from divolgin and laverya October 17, 2024 23:15
@dydx dydx marked this pull request as draft October 18, 2024 17:34
@dydx dydx marked this pull request as ready for review October 18, 2024 17:56
@divolgin divolgin merged commit dfe96f2 into main Oct 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants