Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EC --config-values flag and update automated install docs #2830
Add EC --config-values flag and update automated install docs #2830
Changes from 12 commits
7be3ac4
7437988
1423036
40e2e49
68f51ef
33b11ac
87c60bb
2a99082
5dd7638
c5cc427
faca29f
69e08f0
4ca54a3
1a14a45
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate this readonly and hidden stuff—it confuses me so much. But looking at the table for randomstring, it seems like
readonly
true is what makes it persistent. False is ephemeral. So just wondering if this should be "remove the false ones."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is old enough that I'll make a separate docs story to investigate/confirm... I'm not even sure if the reason that this bullet point appears here actually has to do with ephemeral/persistent values or if it's more like "don't imply to your users that they can set a value for read-only fields"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://app.shortcut.com/replicated/story/116074