error on missing required config

replicatedhq · Jul 4, 2024 · c9d3ef3 · c9d3ef3
1 parent ac65854
commit c9d3ef3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/cmd/kots/cli/template.go b/cmd/kots/cli/template.go
@@ -268,7 +268,10 @@ func pullAndRender(appSlug string, licensePath string, configPath string, localP
 	upstream := pull.RewriteUpstream(appSlug)
 	_, err = pull.Pull(upstream, pullOptions)
 
-	if err != nil && err != pull.ErrConfigNeeded {
+	if err != nil {
+		if err == pull.ErrConfigNeeded {
+			return errors.New("missing required config values to render templates")
+		}
 		return errors.Wrap(err, "failed to pull upstream")
 	}
 

diff --git a/pkg/kotsadmconfig/config.go b/pkg/kotsadmconfig/config.go
@@ -84,6 +84,7 @@ func NeedsConfiguration(appSlug string, sequence int64, isAirgap bool, kotsKinds
 		}
 		for _, item := range group.Items {
 			if IsRequiredItem(item) && IsUnsetItem(item) {
+				log.Info("config item %q is required but not set", item.Name)
 				return true, nil
 			}
 		}