feat: return error if ec version is a pre-release #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the version present in the embedded cluster config is a pre-release, the linter should return an error.
as per conversaions with @salah.
laverya
reviewed
Nov 6, 2024
pkg/ec/lint.go
Outdated
Comment on lines
124
to
126
| if newVersion.PreRelease { | ||
| return &newVersion, true, nil | ||
| } |
There was a problem hiding this comment.
this needs a comment - it looks like we're purposefully not caching prereleases, which I would agree with, but that should be explicitly listed
laverya
approved these changes
Nov 6, 2024
ricardomaraschini
deleted the
ricardomaraschini/sc-115283/linter-should-fail-if-pre-release-ec-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the version present in the embedded cluster config is a pre-release, the linter should return an error.