Add rate limiting for API endpoints #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aron
force-pushed
the
rate-limit
branch
2 times, most recently
from
b0a2b9b
to
4a52aae
Compare
zeke
reviewed
Dec 8, 2023
|
|
||
| // Handle Rate Limiting | ||
| if (response.status === 429) { | ||
| const reset = response.headers.get('X-Ratelimit-Reset') ?? Date.now() + 10_000; |
There was a problem hiding this comment.
TIL numeric separators are a thing in JavaScript!?
There was a problem hiding this comment.
What do you think about using something like ms to make these magic numbers human-friendly?
e.g. ms('10s') instead of 10_000
There was a problem hiding this comment.
No strong opinion honestly, I'd generally err on not sending more stuff to the client unless we used this a lot. but also happy to add it in a follow up.
|
Gave it a quick try in the deployment preview and looks good! thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some basic rate limiting in production for the
/api/predictions/[id]endpoint. We allow a sliding window of 20 requests within 10 seconds to fetch prediction metadata.If rate limits are hit the client will wait for 10 seconds for the window to ease up before retrying the request. This may have the result of the query experience being slower but we need to keep requests reasonable until we can move to a client side implementation.
We also attempt to reduce the load by introducing a backoff for the pings. Instead of pinging every 500ms indefinitely we now slowly increase the time between requests. Looking at the distribution of traffic. Most requests take between 1 & 3 seconds so this shouldn't have a noticable effect. But for longer predictions >10 seconds we'll greatly reduce the number of requests made.