Include timestamp and span-compatible attributes in done files #23
+156
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we can pass along more context through `director` and generally depend on more than an empty file. Connected to PLAT-555
nevillelyh
reviewed
Dec 3, 2024
There was a problem hiding this comment.
We delete a directory when .done is missing so that a step can be retried if it failed previously, e.g. OOM when running CUDA runfile, network issues, yanked torch nightly etc., all of which has happened in prod. Otherwise the directory might be in a corrupted or incomplete state.
|
@nevillelyh Thank you. I'll propose a rework ⌨️ |
|
FWIW everything else looks good, should be good if we just reinstate the |
nevillelyh
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we can pass along more context through
directorand generally depend on more than an empty file.Please note: this also includes a behavior change tois_donethat no longer deletes the directory tree when.doneis not present. I couldn't come up with a reason for why we would want this outside of testing. I'm happy to learn that it's important and we should keep it that way 😇 (although if it needs to be kept that way then I'd like it to have a different name).Update: What was previously
monobase.util:is_doneis nowmonobase.util:require_done_or_rmConnected to PLAT-555