Use venv for Python development #425
Conversation
hemildesai
force-pushed
the
venv_for_development
branch
from
616b70e
to
6a0d43b
Compare
hemildesai
force-pushed
the
venv_for_development
branch
from
6a0d43b
to
6af24dd
Compare
hemildesai
force-pushed
the
venv_for_development
branch
from
88453e5
to
3d9c662
Compare
Signed-off-by: hemildesai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
hemildesai
force-pushed
the
venv_for_development
branch
from
9bcdd62
to
aecea77
Compare
|
Not sure why |
|
Yeah, super weird isn't it. I restarted the test a couple of times so it's a real failure. Maybe it's using a different version of pip because it's inside a virtualenv? I'm trying to figure out what might be different in this installation. |
|
Thanks so much for the contribution btw! I'll do some poking around later today if I get time... |
|
Cool, thanks for looking into it. Let me know if I can help. |
|
@bfirsh it looks like the pip version is the culprit - tensorflow/tensorflow#39130 (comment) |
Signed-off-by: hemildesai <[email protected]>
hemildesai
force-pushed
the
venv_for_development
branch
from
a25568f
to
b36645f
Compare
|
Hah, oh god. Nice find. 🙄 |
|
Several times during this project we've thought "ok we need to burn all Python packaging to the ground and create a new packaging system" but then reminded ourselves we should keep our eyes on the ball, haha. This is also why most of the codebase is in Go -- so we don't have to deal with Python's godawful packaging/dependencies. cc @dscape |
This reverts commit b36645f. Signed-off-by: hemildesai <[email protected]>
Signed-off-by: hemildesai <[email protected]>
|
Yeah, sometimes with issues like this, it can be quite frustrating. |
|
Hey @bfirsh, let me know if this is good to go or if there are any changes required. |
|
Thanks so much @hemildesai! We're just in the process of shipping a release right now so I don't want to change up the development environment while we do that. But, as soon as we've shipped it, this is first thing I'm taking a look at. :) |
|
Sorry for being slow here -- I had a quick look at this the other day. I think it's a bit confusing that the Python library is installed locally in a virtualenv, but the binary is still installed globally. That'll make it easy to get into a situation where different versions installed in two different places. I wonder if we can install the binary inside the venv in development? |
|
@bfirsh Sure. Can you point me to where the binary is installed so that I can change it to be installed in the venv? |
Addresses https://github.com/replicate/replicate/issues/424