Implement RFC9530 Content-Digest as an http.RoundTripper
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements an http.RoundTripper which transparently calculates RFC9530-compatible Content-Digest headers for outgoing requests. This header will be needed if we in future wish to sign request bodies with RFC9421.
Generating new byte buffers for every single processed request is quite
wasteful and generates a lot of work for the GC.
Similarly, the hash.Hash struct can be reused, although this provides
only a small additional benefit.
Before:
goos: darwin
goarch: arm64
pkg: github.com/replicate/go/http/digest
BenchmarkTransport-10 9200 123811 ns/op 1058.65 MB/s 525456 B/op 24 allocs/op
PASS
ok github.com/replicate/go/http/digest 6.684s
After:
goos: darwin
goarch: arm64
pkg: github.com/replicate/go/http/digest
BenchmarkTransport-10 12412 95642 ns/op 1370.45 MB/s 1450 B/op 12 allocs/op
PASS
ok github.com/replicate/go/http/digest 14.619s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an
http.RoundTripperwhich transparently calculates RFC9530-compatible Content-Digest headers for outgoing requests. This header will be needed if we in future wish to sign request bodies with RFC9421.