Improve the build process for Homebrew #1983
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently run into issues where Homebrew's build process for cog doesn't match the build process we use for our own binaries.
This commit makes changes to our build process that will hopefully allow us to update Homebrew to use our Makefile to run its builds.
Use
python -m pip wheel
to build the wheel rather than relying on a manualpip install -e .[dev]
andpython -m build
.Allow COG_VERSION_OVERRIDE and COG_COMMIT_OVERRIDE to specify the version and commit values used by goreleaser.
Set the
-trimpath
flag forgo build
so we don't capture directory names from the Homebrew build process or GitHub Actions.