Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate yaml for forbidden extra fields #5

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

andreasjansson
Copy link
Member

@andreasjansson andreasjansson commented Sep 11, 2024

also small optimization to reuse test model instead of repushing if both train and predict are set.


🚀 This description was created by Ellipsis for commit 726a1b3

Summary:

This PR forbids extra fields in YAML configurations and optimizes model reuse to avoid redundant pushes, with added logging for prediction URLs.

Key points:

  • Added ConfigDict(extra="forbid") to TestCase, FuzzConfig, PredictConfig, TrainConfig, and Config classes in cog_safe_push/config.py to forbid extra fields in YAML.
  • Optimized model reuse in cog_safe_push/main.py by introducing reuse_test_model to avoid redundant pushes when both train and predict are set.
  • Updated cog_safe_push function to handle reuse_test_model parameter.
  • Added logging of prediction URL in cog_safe_push/predict.py for better traceability.

Generated with ❤️ by ellipsis.dev

also small optimization to reuse test model instead of repushing if both train and predict are set.
@andreasjansson andreasjansson merged commit 6fb8710 into main Sep 11, 2024
2 checks passed
@andreasjansson andreasjansson deleted the yaml-validation branch September 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant