Add E2E tests #13
Merged
Add E2E tests #13
+572
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nevillelyh
commented
Dec 2, 2024
nevillelyh
commented
- Remove redundant coglet/_compat from PYTHONPATH
- Remove --working-dir from cog-server.sh
- Log await-explicit-shutdown
- Use any instead of interface{}
- Reset ctx_pid before logging on prediction cancel or failure
- Add tests
nevillelyh
commented
Dec 2, 2024
| func TestPredictionCrash(t *testing.T) { | ||
| e := NewCogTest(t, "sleep") | ||
| e.AppendArgs("--await-explicit-shutdown") | ||
| e.AppendEnvs("PREDICTION_CRASH=1") |
There was a problem hiding this comment.
This makes predict() call sys.exit(1) simulating a Python process hard crash, e.g. OOM or CUDA issue. Legacy Cog just returns an HTTP 503 with no error/log, while Coggo preserves per prediction ID logging plus error, so this is actually an improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.