fix: 1559 transaction handling #551
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
bkrem
approved these changes
Apr 30, 2024
| const CELO_ALFAJORES_CHAIN_ID = 44787; | ||
| const CELO_MAINNET_CHAIN_ID = 42220; | ||
|
|
||
| let valid = false; | ||
| console.log("rpc request", { |
| const transaction = ethers.utils.parseTransaction( | ||
| signedTx.startsWith("0x") ? signedTx : `0x${signedTx}` | ||
| ); | ||
| console.log("parsed transaction", transaction); |
There was a problem hiding this comment.
Suggested change
| console.log("parsed transaction", transaction); |
| signedTx as any | ||
| ).verifySignature(); | ||
| } catch (e) { | ||
| console.warn("fromSerializedTx failed", e); |
There was a problem hiding this comment.
Should be error since this is a failure case?
Suggested change
| console.warn("fromSerializedTx failed", e); | |
| console.error("fromSerializedTx failed", e); |
| transaction.to === tx.to && | ||
| transaction.from === tx.from; | ||
| } catch (e) { | ||
| console.warn("parseTransaction failed", e); |
There was a problem hiding this comment.
Should be an error because it's a failure case not a warning that can be ignored:
Suggested change
| console.warn("parseTransaction failed", e); | |
| console.error("parseTransaction failed", e); |
|
@ganchoradkov can we fix up and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current validation of
eth_signTransactionresult is not sufficient for handling 1559 responses