feat: terms of service / privacy policy checkbox #3207

magiziz · 2024-11-06T18:13:56Z

Description

Added a new feature where users can include a terms of service / privacy policy checkbox.

Type of change

Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-1377

Showcase (Optional)

checkbox-fade.mov

Checklist

Code in this PR is covered by automated tests (Unit tests, E2E tests)
My changes generate no new warnings
I have reviewed my own code
I have filled out all required sections
I have tested my changes on the preview link
Approver of this PR confirms that the changes are tested on the preview link

linear · 2024-11-06T18:13:59Z

APKT-1377 Create checkbox to accept T&Cs before connecting in appkit

changeset-bot · 2024-11-06T18:13:59Z

🦋 Changeset detected

Latest commit: 6f6b3bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages

Name	Type
@reown/appkit-scaffold-ui	Patch
@apps/laboratory	Patch
@reown/appkit	Patch
@reown/appkit-core	Patch
@apps/gallery	Patch
@reown/appkit-ui	Patch
@apps/demo	Patch
@reown/appkit-adapter-ethers	Patch
@reown/appkit-adapter-ethers5	Patch
@reown/appkit-adapter-polkadot	Patch
@reown/appkit-adapter-solana	Patch
@reown/appkit-adapter-wagmi	Patch
@reown/appkit-utils	Patch
@reown/appkit-cdn	Patch
@reown/appkit-common	Patch
@reown/appkit-experimental	Patch
@reown/appkit-polyfills	Patch
@reown/appkit-siwe	Patch
@reown/appkit-siwx	Patch
@reown/appkit-wallet	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-11-06T18:14:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
appkit-gallery	✅ Ready (Inspect)	Visit Preview		Nov 7, 2024 7:51pm
appkit-laboratory	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 7:51pm
appkit-vue-solana	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 7:51pm
appkit-wagmi-cdn-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 7:51pm
vue-wagmi-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 7:51pm
web3modal-gallery	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 7:51pm

github-actions · 2024-11-06T18:16:31Z

Coverage Report for Coverage

Status	Category	Percentage	Covered / Total
🔵	Lines	340.09000000000003%	4496 / 19022
🔵	Statements	340.09000000000003%	4496 / 19022
🔵	Functions	375.86%	371 / 1092
🔵	Branches	465.62%	682 / 1391

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/core/src/utils/ConstantsUtil.ts	100%	100%	100%	100%
packages/core/src/utils/TypeUtil.ts	100%	100%	100%	100%
packages/scaffold-ui/exports/index.ts	0%	0%	0%	0%	1-120
packages/scaffold-ui/src/partials/w3m-all-wallets-widget/index.ts	0%	0%	0%	0%	1-73
packages/scaffold-ui/src/partials/w3m-connect-announced-widget/index.ts	0%	0%	0%	0%	1-84
packages/scaffold-ui/src/partials/w3m-connect-custom-widget/index.ts	0%	0%	0%	0%	1-86
packages/scaffold-ui/src/partials/w3m-connect-external-widget/index.ts	0%	0%	0%	0%	1-65
packages/scaffold-ui/src/partials/w3m-connect-featured-widget/index.ts	0%	0%	0%	0%	1-58
packages/scaffold-ui/src/partials/w3m-connect-injected-widget/index.ts	0%	0%	0%	0%	1-96
packages/scaffold-ui/src/partials/w3m-connect-multi-chain-widget/index.ts	0%	0%	0%	0%	1-72
packages/scaffold-ui/src/partials/w3m-connect-recent-widget/index.ts	0%	0%	0%	0%	1-46
packages/scaffold-ui/src/partials/w3m-connect-recommended-widget/index.ts	0%	0%	0%	0%	1-98
packages/scaffold-ui/src/partials/w3m-connect-walletconnect-widget/index.ts	0%	0%	0%	0%	1-70
packages/scaffold-ui/src/partials/w3m-connector-list/index.ts	0%	0%	0%	0%	1-123
packages/scaffold-ui/src/partials/w3m-email-login-widget/index.ts	0%	0%	0%	0%	1-200
packages/scaffold-ui/src/partials/w3m-legal-checkbox/index.ts	0%	0%	0%	0%	1-59
packages/scaffold-ui/src/partials/w3m-legal-checkbox/styles.ts	0%	0%	0%	0%	1-3
packages/scaffold-ui/src/partials/w3m-legal-footer/index.ts	0%	0%	0%	0%	1-58
packages/scaffold-ui/src/partials/w3m-social-login-list/index.ts	0%	0%	0%	0%	1-131
packages/scaffold-ui/src/partials/w3m-social-login-widget/index.ts	0%	0%	0%	0%	1-236
packages/scaffold-ui/src/partials/w3m-wallet-guide/index.ts	0%	0%	0%	0%	1-67
packages/scaffold-ui/src/partials/w3m-wallet-login-list/index.ts	0%	0%	0%	0%	1-20
packages/scaffold-ui/src/views/w3m-connect-socials-view/index.ts	0%	0%	0%	0%	1-46
packages/scaffold-ui/src/views/w3m-connect-socials-view/styles.ts	0%	0%	0%	0%	1-3
packages/scaffold-ui/src/views/w3m-connect-view/index.ts	0%	0%	0%	0%	1-238
packages/scaffold-ui/src/views/w3m-connect-view/styles.ts	0%	0%	0%	0%	1-3
packages/scaffold-ui/src/views/w3m-connect-wallets-view/index.ts	0%	0%	0%	0%	1-46
packages/scaffold-ui/src/views/w3m-connect-wallets-view/styles.ts	0%	0%	0%	0%	1-3
packages/scaffold-ui/src/views/w3m-onramp-fiat-select-view/index.ts	0%	0%	0%	0%	1-98
packages/scaffold-ui/src/views/w3m-onramp-fiat-select-view/styles.ts	0%	0%	0%	0%	1-3
packages/scaffold-ui/src/views/w3m-onramp-tokens-select-view/index.ts	0%	0%	0%	0%	1-101
packages/scaffold-ui/src/views/w3m-onramp-tokens-select-view/styles.ts	0%	0%	0%	0%	1-3
packages/ui/index.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-checkbox/index.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-checkbox/styles.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-email-input/index.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-input-text/index.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-link/index.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-list-button/index.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-list-item/index.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-list-social/index.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-list-wallet/index.ts	0%	0%	0%	0%
packages/ui/src/composites/wui-logo-select/index.ts	0%	0%	0%	0%
packages/ui/src/utils/JSXTypeUtil.ts	100%	100%	100%	100%
packages/ui/src/utils/ThemeUtil.ts	0%	0%	0%	0%

Generated in workflow #7271 for commit 6f6b3bb by the Vitest Coverage Report Action

enesozturk · 2024-11-06T19:13:44Z

apps/laboratory/src/pages/library/ethers-no-email.tsx

@@ -23,6 +23,7 @@ const modal = createAppKit({
  },
  termsConditionsUrl: 'https://reown.com/terms-of-service',
  privacyPolicyUrl: 'https://reown.com/privacy-policy',
+  enableLegalCheckbox: true,


I think we could move this flag to options.features object. Like features.legalCheckbox? We want to collect all features under this flag

enesozturk

Will test the preview

magiziz added 11 commits October 31, 2024 09:09

feat: terms of policy checkbox

5bf3f6a

refactor: wui-checkbox component

73c50f7

chore: setup checkbox for all terms of policy views

4aedf3c

chore: add graident effect

a8bc01a

chore: add enableLegalCheckbox in OptionsController

ae12324

chore: improve interpolate

3eea4ab

Merge branch 'main' into chore/terms-checkbox

f4fb694

chore: tweak styles

ab92b61

chore: add e2e tests

170f460

chore: add more properties to w3m-legal-checkbox component

4b1de07

chore: tweak

b5a863f

magiziz requested review from tomiir, enesozturk and svenvoskamp November 6, 2024 18:14

magiziz changed the title ~~feat: terms of service / privacy policy checkbox~~ [DO NOT MERGE] feat: terms of service / privacy policy checkbox Nov 6, 2024

vercel bot deployed to Preview – vue-wagmi-example November 6, 2024 18:18 View deployment

vercel bot deployed to Preview – web3modal-gallery November 6, 2024 18:18 View deployment

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 6, 2024 18:21 View deployment

vercel bot deployed to Preview – appkit-laboratory November 6, 2024 18:23 View deployment

vercel bot deployed to Preview – appkit-vue-solana November 6, 2024 18:23 View deployment

enesozturk reviewed Nov 6, 2024

View reviewed changes

enesozturk approved these changes Nov 7, 2024

View reviewed changes

magiziz and others added 3 commits November 7, 2024 09:37

chore: prettify

1703b1b

Merge branch 'main' into chore/terms-checkbox

4767409

chore: changeset

8dfc760

vercel bot deployed to Preview – appkit-vue-solana November 7, 2024 09:42 View deployment

magiziz added 2 commits November 7, 2024 17:36

chore: tweak

dd2a048

chore: format code

f479837

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 7, 2024 17:41 View deployment

vercel bot deployed to Preview – appkit-laboratory November 7, 2024 17:44 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 7, 2024 17:44 View deployment

vercel bot deployed to Preview – appkit-gallery November 7, 2024 17:46 View deployment

vercel bot deployed to Preview – appkit-vue-solana November 7, 2024 17:47 View deployment

chore: rename enableLegalCheckbox to legalCheckbox and add changeset

9c40843

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 7, 2024 18:11 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 7, 2024 18:11 View deployment

vercel bot deployed to Preview – appkit-gallery November 7, 2024 18:14 View deployment

vercel bot deployed to Preview – appkit-laboratory November 7, 2024 18:16 View deployment

vercel bot deployed to Preview – appkit-vue-solana November 7, 2024 18:16 View deployment

chore: remove spacing

da4ff26

vercel bot deployed to Preview – appkit-vue-solana November 7, 2024 19:08 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 7, 2024 19:08 View deployment

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 7, 2024 19:11 View deployment

vercel bot deployed to Preview – appkit-laboratory November 7, 2024 19:12 View deployment

vercel bot deployed to Preview – appkit-gallery November 7, 2024 19:13 View deployment

Merge branch 'main' into chore/terms-checkbox

6f6b3bb

vercel bot deployed to Preview – appkit-wagmi-cdn-example November 7, 2024 19:46 View deployment

vercel bot deployed to Preview – vue-wagmi-example November 7, 2024 19:48 View deployment

vercel bot deployed to Preview – appkit-laboratory November 7, 2024 19:49 View deployment

vercel bot deployed to Preview – appkit-gallery November 7, 2024 19:51 View deployment

vercel bot deployed to Preview – appkit-vue-solana November 7, 2024 19:51 View deployment

magiziz changed the title ~~[DO NOT MERGE] feat: terms of service / privacy policy checkbox~~ feat: terms of service / privacy policy checkbox Nov 7, 2024

tomiir approved these changes Nov 7, 2024

View reviewed changes

tomiir merged commit 3bfbbb9 into main Nov 7, 2024
19 checks passed

tomiir deleted the chore/terms-checkbox branch November 7, 2024 20:02

github-actions bot mentioned this pull request Nov 7, 2024

chore: version packages #3213

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: terms of service / privacy policy checkbox #3207

feat: terms of service / privacy policy checkbox #3207

magiziz commented Nov 6, 2024

linear bot commented Nov 6, 2024

changeset-bot bot commented Nov 6, 2024 •

edited

Loading

vercel bot commented Nov 6, 2024 •

edited

Loading

github-actions bot commented Nov 6, 2024 •

edited

Loading

enesozturk Nov 6, 2024

enesozturk left a comment

feat: terms of service / privacy policy checkbox #3207

feat: terms of service / privacy policy checkbox #3207

Conversation

magiziz commented Nov 6, 2024

Description

Type of change

Associated Issues

Showcase (Optional)

Checklist

linear bot commented Nov 6, 2024

changeset-bot bot commented Nov 6, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Nov 6, 2024 • edited Loading

github-actions bot commented Nov 6, 2024 • edited Loading

Coverage Report for Coverage

enesozturk Nov 6, 2024

Choose a reason for hiding this comment

enesozturk left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Nov 6, 2024 •

edited

Loading

vercel bot commented Nov 6, 2024 •

edited

Loading

github-actions bot commented Nov 6, 2024 •

edited

Loading