-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(presets): switch kiota monorepo to group #32437
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the versions between repos kept in-sync? If not then this is probably not right for a monorepo grouping and instead might be part of group:recommended, or just a standalone grouping of its own
They are not, only the version in each repo are in sync. I'll port this over to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this new default grouping.
those packages should be grouped by their monorepo when the repo published them with the same version.
the other groups should be fully optional and opt-in, because they create immortal PRs.
Is what you're saying define multiple monorepos for each Kiota repo and an optional group to group all the monorepos? That makes sense. For context, each kiota repo publishes multiple packages, versioned together, but the versions are not the same across repos. (i.e., the .NET packages are at |
What % of users would you estimate want to update them all together at once? If it's very high, then adding it to group:recommended makes sense. If it's not high, and this is more of an "opinionated" grouping, then it is better to stand on its own. |
i think most user are only using one tech stack, eg npm or dotnet on a single repo |
Hard to say exactly, Kiota is fairly new. I would guesstimate that 50% of users have a dependency on the Kiota library itself ( Most would only have one language like @viceice mentioned for the bindings. In my case, it's a C# backend with a TypeScript frontend. There's an argument that any updates to the generation code ( But I as a user would be okay with the default behavior for 2 PRs, one for the actual generation kiota libraries, and another for the bindings. |
Doesn't this change technically demand for a migration step? Folks might reference "monorepo:kiota", but it won't resolve any longer. |
Changes
Added other kiota repositories to the
kiota
monorepo preset.Context
#32164 added the
kiota
repository, but it also spans multiple repos for each language it supports.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: