refactor(gitlab): ensure getPrList() runtime integrity #32291
+128
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
requested changes
Nov 7, 2024
lib/modules/platform/gitlab/index.ts
Outdated
Comment on lines
868
to
874
| const updatedPr: Pr = massagePr({ | ||
| number: updatedPrInfo.iid, | ||
| state: updatedPrInfo.state === 'opened' ? 'open' : updatedPrInfo.state, | ||
| title: updatedPrInfo.title, | ||
| createdAt: updatedPrInfo.created_at, | ||
| sourceBranch: updatedPrInfo.source_branch, | ||
| }); |
There was a problem hiding this comment.
Similar code to this seems duplicated throughout this gitlab module. Can any of it be consolidated?
secustor
reviewed
Nov 7, 2024
lib/modules/platform/gitlab/index.ts
Outdated
Comment on lines
859
to
865
| await gitlabApi.putJson<{ | ||
| iid: number; | ||
| source_branch: string; | ||
| title: string; | ||
| state: string; | ||
| created_at: string; | ||
| }>(`projects/${config.repository}/merge_requests/${iid}`, { body }) |
There was a problem hiding this comment.
Create a type for that generic.
Can we use Zod here?
There was a problem hiding this comment.
Yes, I think this is necessary can we can start with Gitlab as the types are messy here. A task for another PR though as we need to also handle the other functions like createPr, getPrList, getPr, getBranchPr, and findPr.
6 tasks
|
Blocked by: #32428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the runtime pr list when a pr is updated
Context
Ref: #32040
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: