Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipenv): Use "detect-tools" for constraints detection #29787

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(pipenv): Use "detect-tools" for constraints detection #29787

wants to merge 18 commits into from

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jun 20, 2024 •
edited
Loading

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov changed the title feat(pipenv): Use "@renovatebot/detect-tools" for constraints detection feat(pipenv): Use "detect-tools" for constraints detection Jun 20, 2024
@zharinov zharinov marked this pull request as draft June 21, 2024 15:20
@zharinov zharinov marked this pull request as ready for review July 1, 2024 13:48
@zharinov zharinov marked this pull request as draft July 1, 2024 14:19
@zharinov zharinov marked this pull request as ready for review July 2, 2024 16:36
@zharinov zharinov added the ci:fulltest Run full test suite on all platforms label Jul 2, 2024
@zharinov zharinov marked this pull request as draft July 2, 2024 16:37
@zharinov zharinov marked this pull request as ready for review July 2, 2024 16:37
@zharinov zharinov requested review from rarkins and viceice July 2, 2024 16:54
viceice
viceice reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new code looks promising, please also let me review changes to the detect tools. I need them later for containerbase.

lib/modules/manager/pipenv/artifacts.ts
@@ -1,5 +1,5 @@
import * as detectTools from '@renovatebot/detect-tools';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the import star is required? can't we use a default export?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice left review comments

@rarkins rarkins Awaiting requested review from rarkins

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move tool detection to renovatebot/detect-tools
2 participants
@zharinov @viceice